Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: simplify word description sentences #2963

Merged
merged 2 commits into from
Jun 22, 2024
Merged

docs: simplify word description sentences #2963

merged 2 commits into from
Jun 22, 2024

Conversation

Shinigami92
Copy link
Member

closes #2937

@Shinigami92 Shinigami92 added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent m: word Something is referring to the word module labels Jun 21, 2024
@Shinigami92 Shinigami92 added this to the vAnytime milestone Jun 21, 2024
@Shinigami92 Shinigami92 self-assigned this Jun 21, 2024
@Shinigami92 Shinigami92 requested a review from a team as a code owner June 21, 2024 16:46
@netlify Netlify
Copy link

netlify bot commented Jun 21, 2024 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit d1e9389
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6675b05b7c907f0008c3e71d
😎 Deploy Preview https://deploy-preview-2963.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Jun 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (ff2dae4) to head (d1e9389).

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2963      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.01%     
==========================================
  Files        2989     2989              
  Lines      216081   216081              
  Branches      952      947       -5     
==========================================
- Hits       216010   215994      -16     
- Misses         71       87      +16
Files Coverage Δ
src/modules/word/index.ts 98.88% <100.00%> (ø)

... and 2 files with indirect coverage changes

ST-DDT
ST-DDT previously approved these changes Jun 21, 2024
View reviewed changes
@ST-DDT ST-DDT requested review from a team June 21, 2024 16:51
matthewmayer
matthewmayer previously approved these changes Jun 21, 2024
View reviewed changes
src/modules/word/index.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 dismissed stale reviews from matthewmayer and ST-DDT via d1e9389 June 21, 2024 16:54
@ST-DDT ST-DDT requested review from a team June 21, 2024 16:56
@xDivisionByZerox xDivisionByZerox merged commit 05237e4 into next Jun 22, 2024
23 checks passed
@xDivisionByZerox xDivisionByZerox deleted the 2937-enhance-jsdoc-sentences-of-word-module branch June 22, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: docs Improvements or additions to documentation m: word Something is referring to the word module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.

Enhance JSDoc sentences of word module
4 participants
@Shinigami92 @matthewmayer @ST-DDT @xDivisionByZerox