Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add npm to social links #2971

Merged
merged 2 commits into from
Jun 24, 2024
Merged

docs: add npm to social links #2971

merged 2 commits into from
Jun 24, 2024

Conversation

xDivisionByZerox
Copy link
Member

Description

Add a NPM social icon to the navigation of our documentation page.

image

@xDivisionByZerox xDivisionByZerox added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Jun 22, 2024
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Jun 22, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team June 22, 2024 20:13
@xDivisionByZerox xDivisionByZerox self-assigned this Jun 22, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner June 22, 2024 20:13
Copy link

netlify bot commented Jun 22, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit ee850b7
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66791051e9ce9b0008242419
😎 Deploy Preview https://deploy-preview-2971.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (6b1159d) to head (1072f82).

Current head 1072f82 differs from pull request most recent head ee850b7

Please upload reports for the commit ee850b7 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2971    +/-   ##
========================================
  Coverage   99.95%   99.96%            
========================================
  Files        2989     2989            
  Lines      216081   216081            
  Branches      596      951   +355     
========================================
+ Hits       215986   216002    +16     
+ Misses         95       79    -16     

see 2 files with indirect coverage changes

@ST-DDT
Copy link
Member

ST-DDT commented Jun 22, 2024

Not sure which social links we need.

@ST-DDT ST-DDT requested a review from a team June 22, 2024 21:43
@xDivisionByZerox
Copy link
Member Author

Not sure which social links we need.

You think a user might get overwhelmed by the amount of icons if we would put in all applicable icon?

@matthewmayer
Copy link
Contributor

I think that is a concern especially for less well known ones like OpenCollective.

@matthewmayer
Copy link
Contributor

I think 6 is tolerable. I would try to avoid 7 or more.

@ST-DDT ST-DDT enabled auto-merge (squash) June 24, 2024 06:21
@ST-DDT ST-DDT merged commit 336162c into next Jun 24, 2024
21 checks passed
@ST-DDT ST-DDT deleted the docs/add-npm-to-social-links branch June 24, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants