Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update eslint #3100

Merged
merged 1 commit into from
Sep 14, 2024
Merged

chore(deps): update eslint #3100

merged 1 commit into from
Sep 14, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 9, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@eslint/js (source) 9.9.1 -> 9.10.0 age adoption passing confidence
eslint (source) 9.9.1 -> 9.10.0 age adoption passing confidence
eslint-plugin-jsdoc 50.2.2 -> 50.2.3 age adoption passing confidence
typescript-eslint (source) 8.3.0 -> 8.5.0 age adoption passing confidence

Release Notes

eslint/eslint (@​eslint/js)

v9.10.0

Compare Source

eslint/eslint (eslint)

v9.10.0

Compare Source

gajus/eslint-plugin-jsdoc (eslint-plugin-jsdoc)

v50.2.3

Compare Source

Bug Fixes
  • require-jsdoc: avoid erring on static blocks (8222262)
typescript-eslint/typescript-eslint (typescript-eslint)

v8.5.0

Compare Source

This was a version bump only for typescript-eslint to align it with other projects, there were no code changes.

You can read about our versioning strategy and releases on our website.

v8.4.0

Compare Source

This was a version bump only for typescript-eslint to align it with other projects, there were no code changes.

You can read about our versioning strategy and releases on our website.


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner September 9, 2024 00:39
@renovate renovate bot added c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent labels Sep 9, 2024
@renovate renovate bot added this to the vAnytime milestone Sep 9, 2024
Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 0034ee3
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66e5fa8849c7820008003ea2
😎 Deploy Preview https://deploy-preview-3100.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (a11ddb4) to head (0034ee3).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3100   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2776     2776           
  Lines      226260   226260           
  Branches      944      945    +1     
=======================================
+ Hits       226198   226199    +1     
+ Misses         62       61    -1     

see 1 file with indirect coverage changes

@renovate renovate bot force-pushed the renovate/eslint branch 6 times, most recently from 41cde30 to f228040 Compare September 9, 2024 23:03
ST-DDT
ST-DDT previously approved these changes Sep 10, 2024
@ST-DDT ST-DDT requested review from a team September 10, 2024 09:12
Shinigami92
Shinigami92 previously approved these changes Sep 10, 2024
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valuable to note: v9.10 ships their own types!

import-brain
import-brain previously approved these changes Sep 10, 2024
@xDivisionByZerox
Copy link
Member

Valuable to note: v9.10 ships their own types!

Does that mean we can remove the packages @eslint-types/*? Or am I misunderstanding these implications?

@renovate renovate bot force-pushed the renovate/eslint branch 3 times, most recently from ffdf52f to 8050f4b Compare September 14, 2024 20:32
@ST-DDT
Copy link
Member

ST-DDT commented Sep 14, 2024

Valuable to note: v9.10 ships their own types!

Does that mean we can remove the packages @eslint-types/*? Or am I misunderstanding these implications?

Why might be able to do that anyway - see also #3106

@Shinigami92
Copy link
Member

Valuable to note: v9.10 ships their own types!

Does that mean we can remove the packages @eslint-types/*? Or am I misunderstanding these implications?

I did not explore them yet, but partly yes
However, I did not update @eslint-types/* for some time now and I plan to archive them in favor of typescript-eslint new config utility
But right now, these solutions do not provide autocompletion for rules

@ST-DDT ST-DDT merged commit 2c329b0 into next Sep 14, 2024
23 checks passed
@ST-DDT ST-DDT deleted the renovate/eslint branch September 14, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants