Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: rewrite database tests #393

Merged
merged 5 commits into from
Feb 10, 2022
Merged

test: rewrite database tests #393

merged 5 commits into from
Feb 10, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 self-assigned this Feb 1, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 1, 2022 19:45
@Shinigami92 Shinigami92 mentioned this pull request Feb 1, 2022
Closed
ST-DDT
ST-DDT previously approved these changes Feb 1, 2022
View reviewed changes
@ST-DDT ST-DDT requested a review from a team February 1, 2022 22:38
ST-DDT
ST-DDT previously approved these changes Feb 3, 2022
View reviewed changes
@codecov
Copy link

codecov bot commented Feb 4, 2022 •
edited
Loading

Codecov Report

Merging #393 (302c616) into main (3901123) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 302c616 differs from pull request most recent head 008e192. Consider uploading reports for the commit 008e192 to get more accurate results

@@           Coverage Diff           @@
##             main     #393   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files        1920     1920           
  Lines      174272   174272           
  Branches      893      893           
=======================================
+ Hits       173099   173100    +1     
+ Misses       1117     1116    -1     
  Partials       56       56
Impacted Files Coverage Δ
src/helpers.ts 99.47% <0.00%> (+0.17%) ⬆️

ST-DDT
ST-DDT previously approved these changes Feb 4, 2022
View reviewed changes
@ST-DDT ST-DDT requested a review from a team February 4, 2022 23:39
@ST-DDT ST-DDT added the needs rebase There is a merge conflict label Feb 6, 2022
@Shinigami92 Shinigami92 removed the needs rebase There is a merge conflict label Feb 6, 2022
ST-DDT
ST-DDT previously approved these changes Feb 6, 2022
View reviewed changes
@ST-DDT ST-DDT requested a review from a team February 6, 2022 15:14
@Shinigami92 Shinigami92 merged commit 4b5afb3 into main Feb 10, 2022
@Shinigami92 Shinigami92 deleted the test-database-rewrite branch February 10, 2022 20:14
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@Shinigami92 @demipel8
test: rewrite database tests (faker-js#393)
64ba148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@prisis prisis prisis approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: test
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.
3 participants
@Shinigami92 @ST-DDT @prisis