Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: rewrite helpers tests #499

Merged
merged 12 commits into from
Feb 19, 2022
Merged

test: rewrite helpers tests #499

merged 12 commits into from
Feb 19, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 self-assigned this Feb 16, 2022
@Shinigami92 Shinigami92 mentioned this pull request Feb 16, 2022
Closed
@Shinigami92 Shinigami92 marked this pull request as ready for review February 17, 2022 16:58
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 17, 2022 16:58
@codecov
Copy link

codecov bot commented Feb 17, 2022 •
edited
Loading

Codecov Report

Merging #499 (d038e2e) into main (431c108) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #499   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1919     1919           
  Lines      176333   176333           
  Branches      903      906    +3     
=======================================
+ Hits       175176   175178    +2     
+ Misses       1101     1099    -2     
  Partials       56       56
Impacted Files Coverage Δ
src/helpers.ts 99.54% <100.00%> (ø)
src/vendor/unique.ts 97.58% <0.00%> (+1.61%) ⬆️

ST-DDT
ST-DDT previously approved these changes Feb 17, 2022
View reviewed changes
src/helpers.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested a review from a team February 17, 2022 17:19
Shinigami92
Shinigami92 commented Feb 17, 2022
View reviewed changes
src/helpers.ts Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 commented Feb 17, 2022
View reviewed changes
src/helpers.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested a review from a team February 17, 2022 21:31
@ST-DDT ST-DDT merged commit c4da9c0 into main Feb 19, 2022
@ST-DDT ST-DDT deleted the rewrite-helpers-test branch February 19, 2022 21:42
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@Shinigami92 @demipel8
test: rewrite helpers tests (faker-js#499)
a67e692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@prisis prisis prisis approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: test
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.
3 participants
@Shinigami92 @ST-DDT @prisis