Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate system #90

Merged
merged 3 commits into from
Jan 14, 2022
Merged

feat: migrate system #90

merged 3 commits into from
Jan 14, 2022

Conversation

Shinigami92
Copy link
Member

test with npm run build && npx mocha test/system.unit.js

}
});

const types = setToArray(typeSet);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This const is not used

});

const types = setToArray(typeSet);
const extensions = setToArray(extensionSet);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This const is not used

});

const types = setToArray(typeSet);
const extensions = setToArray(extensionSet);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for this


const types = setToArray(typeSet);
const extensions = setToArray(extensionSet);
const mimeTypeKeys = Object.keys(this.faker.definitions.system.mimeTypes);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this

}
});

const types = setToArray(typeSet);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not used too

did they just copy past it...


const types = setToArray(typeSet);
const extensions = setToArray(extensionSet);
const mimeTypeKeys = Object.keys(this.faker.definitions.system.mimeTypes);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this

@Shinigami92 Shinigami92 merged commit ecf5e40 into migrate-to-typescript Jan 14, 2022
@Shinigami92 Shinigami92 deleted the migrate-system branch January 14, 2022 16:16
Shinigami92 added a commit that referenced this pull request Jan 14, 2022
Shinigami92 added a commit that referenced this pull request Jan 14, 2022
damienwebdev pushed a commit that referenced this pull request Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants