-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make image registries configurable for falco-exporter
and falcosidekick
#253
Conversation
Co-authored-by: Gerald Pape <[email protected]>
…s into add-github-action
Add github action for syncing
Split up github jobs
Run in sequence
@stone-z: Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stone-z The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @stone-z! It looks like this is your first PR to falcosecurity/charts 🎉 |
Signed-off-by: Zach Stone <[email protected]>
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Closing in favor of #254 -- sorry for the noise |
What type of PR is this?
/kind feature
/kind chart-release
Any specific area of the project related to this PR?
/area falco-exporter-chart
/area falcosidekick-chart
What this PR does / why we need it:
This PR allows configuring the registry to use when pulling
falco-exporter
andfalcosidekick
. Thefalco
chart already has this capability, so this just aligns the other charts.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I added "Unreleased" changelogs and did not bump the chart version since I haven't contributed here before, but would be happy to bump the versions if that is preferrededit: the linter has corrected me. I've bumped the versions.
Checklist