Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make image registries configurable for falco-exporter and falcosidekick #253

Closed
wants to merge 14 commits into from

Conversation

stone-z
Copy link
Contributor

@stone-z stone-z commented Jul 19, 2021

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

What this PR does / why we need it:

This PR allows configuring the registry to use when pulling falco-exporter and falcosidekick. The falco chart already has this capability, so this just aligns the other charts.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I added "Unreleased" changelogs and did not bump the chart version since I haven't contributed here before, but would be happy to bump the versions if that is preferred

edit: the linter has corrected me. I've bumped the versions.

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana
Copy link
Contributor

poiana commented Jul 19, 2021

@stone-z: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link
Contributor

poiana commented Jul 19, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stone-z
To complete the pull request process, please assign nibalizer after the PR has been reviewed.
You can assign the PR to them by writing /assign @nibalizer in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from leodido and nibalizer July 19, 2021 18:41
@poiana
Copy link
Contributor

poiana commented Jul 19, 2021

Welcome @stone-z! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana poiana added the size/M label Jul 19, 2021
Signed-off-by: Zach Stone <[email protected]>
@poiana
Copy link
Contributor

poiana commented Jul 19, 2021

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stone-z stone-z mentioned this pull request Jul 19, 2021
3 tasks
@stone-z
Copy link
Contributor Author

stone-z commented Jul 19, 2021

Closing in favor of #254 -- sorry for the noise

@stone-z stone-z closed this Jul 19, 2021
@stone-z stone-z deleted the configurable-registry branch July 20, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants