-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base64 format fix #1033
Base64 format fix #1033
Conversation
Signed-off-by: Lorenzo Fontana <[email protected]> Co-Authored-By: Leonardo Di Donato <[email protected]>
/hold |
Continuation of the comments in #988 - This is the expected output with json enabled {
"output": "15:11:12.275341197: Notice Yo (err=G1swbRtbMDE7MzRtLhtbMG0K)",
"priority": "Notice",
"rule": "Test",
"time": "2020-02-04T14:11:12.275341197Z",
"output_fields": {
"evt.buffer": "G1swbRtbMDE7MzRtLhtbMG0K",
"evt.time": 1580825472275341300
}
} And this is with json disabled:
|
/hold cancel |
This was broken since 0.13.0 |
LGTM label has been added. Git tree hash: 05aa49ffaab83b1085c57223ace9d4d70106c95a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, mstemm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This PR deprecates PR #988 fixing the issue with base64 format (with/without json enabled).
Which issue(s) this PR fixes:
Fixes #987
Special notes for your reviewer:
Does this PR introduce a user-facing change?: