Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule update: only detect sa created in kube namespace with success #1117

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented Mar 24, 2020

Signed-off-by: kaizhe [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:
kops tries to create kube-proxy and kube-dns sa in kube-system namespace every minute which triggers rule Service Account Created in Kube Namespace. Restrict the condition to only detect a successfully event.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(Service Account Created in Kube Namespace): only detect sa created in kube namespace with success

mstemm
mstemm previously approved these changes Mar 25, 2020
@poiana
Copy link
Contributor

poiana commented Mar 25, 2020

LGTM label has been added.

Git tree hash: 76f5a8791955b4c973f0150dac6e6e69132acdf0

Copy link
Contributor

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job as always here Kaizhe! As per the other PR, rule changes release notes need to follow the convention here

…ed in kube namespace with success

Signed-off-by: kaizhe <[email protected]>
@poiana
Copy link
Contributor

poiana commented Mar 27, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 6834649 into master Mar 27, 2020
@poiana poiana deleted the kh_fix-fp-create-sa-in-kube-system branch March 27, 2020 12:03
@leodido leodido added this to the 0.22.0 milestone Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants