Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix packages scripts #1148

Merged
merged 3 commits into from
Apr 17, 2020
Merged

Hotfix packages scripts #1148

merged 3 commits into from
Apr 17, 2020

Conversation

leodido
Copy link
Member

@leodido leodido commented Apr 17, 2020

What type of PR is this?

/kind bug

/kind cleanup

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

It fixes the pre/post install/uninstall scripts for packages (mainly RPM).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: correct driver path (/usr/src/falco-<driver_version>) for RPM package

leodido and others added 3 commits April 17, 2020 11:00
@leodido @fntlnz
fix(scripts/rpm): obtain the driver version (now different from the F…
596f35c 
…alco version)

Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido @fntlnz
fix(scripts/debian): refinements to the scripts for DEB package
e57e10f 
Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido @fntlnz
build: move packages scripts via CMake
b2e621f 
Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@poiana poiana requested review from fntlnz and mfdii April 17, 2020 11:05
@poiana poiana added the size/M label Apr 17, 2020
@leodido
Copy link
Member Author

leodido commented Apr 17, 2020

/milestone 0.21.0

@poiana
Copy link
Contributor

poiana commented Apr 17, 2020

@leodido: The provided milestone is not valid for this repository. Milestones in this repository: [0.22.1, 0.23.0, 1.0.0]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 0.21.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leodido
Copy link
Member Author

leodido commented Apr 17, 2020

SORRY, @poiana I made a mistake! :D

/milestone 0.22.1

@poiana poiana added this to the 0.22.1 milestone Apr 17, 2020
@fntlnz
Copy link
Contributor

fntlnz commented Apr 17, 2020

POIANA STOPS THE DRAMA

@poiana
Copy link
Contributor

poiana commented Apr 17, 2020

LGTM label has been added.

Git tree hash: 8a139ab8fd3d63f45d087bf52fb69a24c1c89f5a

leogr
leogr approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx @leodido 🙏

@poiana
Copy link
Contributor

poiana commented Apr 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 9f6833e into master Apr 17, 2020
@poiana poiana deleted the hotfix/rpm-scripts branch April 17, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fntlnz fntlnz fntlnz approved these changes

@leogr leogr leogr approved these changes

@mfdii mfdii Awaiting requested review from mfdii

Assignees

@fntlnz fntlnz

@leogr leogr

Labels
approved area/build dco-signoff: yes kind/bug kind/cleanup lgtm release-note size/M
Projects
None yet
Milestone
0.22.1
Development

Successfully merging this pull request may close these issues.
4 participants
@leodido @poiana @fntlnz @leogr