Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(docker/event-generator): remove the event-generator #1156

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

leogr
Copy link
Member

@leogr leogr commented Apr 21, 2020

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1089

Special notes for your reviewer:

  1. This PR deliberately ignore any references to the event-generator that's still included below /integrations because of Move "integrations" to another repo #1145
  2. There are some references to the event-generator below /test, those refer to previously built traces that can be left as-is.
  3. This PR should be kept on hold until the first version of the new event-generator is out

/hold

Does this PR introduce a user-facing change?:

update(docker/event-generator): remove the event-generator from Falco repository

@leogr
Copy link
Member Author

leogr commented Apr 22, 2020

event-generator ready, still on hold for falcosecurity/falco-website#185
cc @leodido

@poiana
Copy link
Contributor

poiana commented Apr 22, 2020

LGTM label has been added.

Git tree hash: 6c420c57b2cbb0ceb3f5b1a91b602d0fe1b59d0e

@leodido leodido added this to the 0.23.0 milestone Apr 22, 2020
@leogr
Copy link
Member Author

leogr commented Apr 24, 2020

DONE falcosecurity/falco-website#187
/hold cancel

@poiana
Copy link
Contributor

poiana commented Apr 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 9915b90 into master Apr 24, 2020
@poiana poiana deleted the cleanup/event-generator branch April 24, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move event-generator
4 participants