-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct "drivers build gruid" URLs #1160
Conversation
Co-authored-by: Lorenzo Fontana <[email protected]> Signed-off-by: Leonardo Di Donato <[email protected]>
/cc @fntlnz |
LGTM label has been added. Git tree hash: 06a5746dad6369b1d08c435a3f280574fca09996
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Lorenzo Fontana [email protected]
Signed-off-by: Leonardo Di Donato [email protected]
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
NONE
What this PR does / why we need it:
It fixes the URL from which the
falco-driver-loader
script fetches the drivers.In fact, the correct URL does not contain the distinction between the driver type (eBPF probe or kernel module): the structure is flat on the server.
Eg.,
https://dl.bintray.com/driver/$driver_version$/falco_$target$_$kernelrelease$_$kernelversion$.[ko|o]
Which issue(s) this PR fixes:
Fixes #1125
Special notes for your reviewer:
Does this PR introduce a user-facing change?: