Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmake/modules): update driver to support kernels 5.6.y #1174

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

leodido
Copy link
Member

@leodido leodido commented Apr 30, 2020

Co-authored-by: Lorenzo Fontana [email protected]
Signed-off-by: Leonardo Di Donato [email protected]

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?
/area build

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1173
Refs draios/sysdig#1621

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: support Falco driver on Linux kernels 5.6.y

Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
Copy link
Member Author

leodido commented Apr 30, 2020

/cc @fntlnz
/cc @kris-nova

@krisnova
Copy link
Contributor

/approve

Copy link
Contributor

@krisnova krisnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bravo!

@poiana
Copy link
Contributor

poiana commented Apr 30, 2020

LGTM label has been added.

Git tree hash: d3ec353cbeccc49cee536bda2bb18ff69f8b5417

@poiana
Copy link
Contributor

poiana commented Apr 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, kris-nova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fntlnz fntlnz merged commit 0367068 into master Apr 30, 2020
@poiana poiana deleted the fix/driver-kernel-5.6.y branch April 30, 2020 18:12
@krisnova
Copy link
Contributor

krisnova commented Apr 30, 2020

So I think this broke our driver build.

Has anyone been able to compile the driver with this new version?

I am testing on 4.19.118 and will report my findings.

@fntlnz
Copy link
Contributor

fntlnz commented May 2, 2020

@kris-nova - Can you post more details? You mean the process of building a driver from source or our automated driver building process?

I tested with against the longterm kernels and @nathan-b - the actual patch author also tested in their environment: draios/sysdig#1621 (comment)

@fntlnz
Copy link
Contributor

fntlnz commented May 2, 2020

Also thanks for testing this out @kris-nova we definitely need to understand what happened to your build before we release because releasing a broken driver might be a huge deal for the project

@nathan-b
Copy link
Contributor

nathan-b commented May 4, 2020

Our automated tests have been running with this change (both eBPF and kmod) for nearly a week now. I'm not saying that I didn't break anything, but I don't think I broke everything ;)

@fntlnz
Copy link
Contributor

fntlnz commented May 8, 2020

So this is ready to ship into the next Falco release! Thanks for the fix @nathan-b !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Falco drivers does not support Linux kernel 5.6.y
5 participants