rule(list falco_privileged_images): add calico/node without registry … #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prefix Signed-off-by: Christian Zunker <[email protected]>
poiana
added
size/XS
release-note
and removed
do-not-merge/release-note-label-needed
labels
leodido
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
Hit by this false positive during a live stream (thanks to the Demo Gods!) 🤣
https://youtu.be/4jJaDf6BYJQ?t=1510
Thus, /approve
|
LGTM label has been added. Git tree hash: a1fe77c84f262edf6acdf5c47a3d1e3eed576cf4
|
|
/milestone 0.27.0 |
leogr
approved these changes
Oct 30, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…prefix
Signed-off-by: Christian Zunker [email protected]
What type of PR is this?
/kind bug
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
add calico/node without registry prefix to prevent false positive alerts
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: