rule (Write below monitored dir): Clean up and use glob matching. #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Lawrence <[email protected]>
Signed-off-by: Shane Lawrence <[email protected]>
|
LGTM label has been added. Git tree hash: 37cc2fda5ac9cb2256eef55a976d9993fe240726
|
|
/milestone 0.28.0 |
|
/hold to let other PRs get merged, feel free to un-hold once approved by the 2 maintainers |
fntlnz
approved these changes
Mar 12, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shane Lawrence [email protected]
What type of PR is this?
/kind cleanup
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
This cleans up the
Write below monitored dirrule by changing its lists and macros. Theuser_ssh_directorymacro was created with a less precise condition while awaiting draios/sysdig#1152, but the fix has been widely available for some time now.Which issue(s) this PR fixes:
Clean up only, no bug fixes.
Fixes #Special notes for your reviewer:
Does this PR introduce a user-facing change?:
I hope not!