Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add known k8s service accounts #1659

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

sboschman
Copy link
Contributor

@sboschman sboschman commented May 25, 2021

/kind rule-update
/area rules

What this PR does / why we need it:

Add namespace-controller, statefulset-controller, disruption-controller, job-controller, horizontal-pod-autoscaler and persistent-volume-binder as additional default k8s controller service accounts to the known_sa_list list. This addition prevents these controllers from triggering a warning as they are created in the kube-system namespace.

These controllers are default k8s controllers according to the docs (https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/)

--controllers strings     Default: "*"

A list of controllers to enable. '*' enables all on-by-default controllers, 'foo' enables the controller named 'foo', '-foo' disables the controller named 'foo'.All controllers: attachdetach, bootstrapsigner, cloud-node-lifecycle, clusterrole-aggregation, cronjob, csrapproving, csrcleaner, csrsigning, daemonset, deployment, disruption, endpoint, endpointslice, endpointslicemirroring, ephemeral-volume, garbagecollector, horizontalpodautoscaling, job, namespace, nodeipam, nodelifecycle, persistentvolume-binder, persistentvolume-expander, podgc, pv-protection, pvc-protection, replicaset, replicationcontroller, resourcequota, root-ca-cert-publisher, route, service, serviceaccount, serviceaccount-token, statefulset, tokencleaner, ttl, ttl-after-finishedDisabled-by-default controllers: bootstrapsigner, tokencleaner

rule(list known_sa_list): add namespace-controller, statefulset-controller, disruption-controller, job-controller, horizontal-pod-autoscaler and persistent-volume-binder as allowed service accounts in the kube-system namespace

@poiana
Copy link
Contributor

poiana commented May 25, 2021

Welcome @sboschman! It looks like this is your first PR to falcosecurity/falco 🎉

Signed-off-by: Sverre Boschman
@leogr
Copy link
Member

leogr commented May 27, 2021

/milestone 0.29.0

@poiana poiana added this to the 0.29.0 milestone May 27, 2021
@Kaizhe
Copy link
Contributor

Kaizhe commented Jun 4, 2021

/lgtm

@poiana
Copy link
Contributor

poiana commented Jun 4, 2021

LGTM label has been added.

Git tree hash: af48f3e2e92b9194331f67c93a99e5cc75a21ec5

@poiana poiana added the approved label Jun 4, 2021
Copy link
Contributor

@Kaizhe Kaizhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/milestone 0.29.0

@poiana
Copy link
Contributor

poiana commented Jun 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kaizhe, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 35dc315 into falcosecurity:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants