update(tests): remove token_bucket unit tests
#1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leogr
previously approved these changes
Nov 22, 2021
|
LGTM label has been added. Git tree hash: 925cda58dede0c0cfcfc7030efe41b65e8b591a1
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mstemm
previously approved these changes
Dec 6, 2021
Signed-off-by: Jason Dellaluce <[email protected]>
jasondellaluce
force-pushed
the
test/remove-token-bucket-test
branch
from
b214022
to
345f9e8
Compare
leogr
approved these changes
Dec 21, 2021
|
LGTM label has been added. Git tree hash: adc2244958343205864ee21f06f02cdef94337d9
|
mstemm
approved these changes
Jan 4, 2022
|
/milestone 0.31.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Dellaluce [email protected]
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area tests
What this PR does / why we need it:
This removes the leftover unit tests for
token_bucket, which was recently removed from the Falco repository and is now only part oflibsinsp. See 👇🏼#1753
falcosecurity/libs@ca51f17
Which issue(s) this PR fixes:
Special notes for your reviewer:
We may want to port this tests to
libsisnpin the future, which however uses a different framework for unit testing. I opened an issue inlibsfor this: falcosecurity/libs#137Does this PR introduce a user-facing change?: