Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): do not show plugin options in musl optimized builds #1871

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

LucaGuerra
Copy link
Contributor

@LucaGuerra LucaGuerra commented Jan 26, 2022

Signed-off-by: Luca Guerra [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Falco can be built with musl-libc but won't have plugin support in that case. Do not display the relevant option in the command line help. Likewise, do not include plugin directories as they cannot be used.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@jasondellaluce
Copy link
Contributor

This addresses the issue at 👉🏼 #1857 (comment)

@jasondellaluce jasondellaluce mentioned this pull request Jan 26, 2022
51 tasks
@leogr
Copy link
Member

leogr commented Jan 26, 2022

/milestone 0.31.0

@poiana poiana added this to the 0.31.0 milestone Jan 26, 2022
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 26, 2022

LGTM label has been added.

Git tree hash: 14951ee75834beed6a68b242c879a33392a6fd02

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member

leogr commented Jan 26, 2022

Closing and reopening to trigger our beloved @poiana ❤️

/close

@poiana poiana closed this Jan 26, 2022
@poiana
Copy link
Contributor

poiana commented Jan 26, 2022

@leogr: Closed this PR.

In response to this:

Closing and reopening to trigger our beloved @poiana ❤️

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented Jan 26, 2022

/reopen

@poiana poiana reopened this Jan 26, 2022
@poiana
Copy link
Contributor

poiana commented Jan 26, 2022

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana merged commit c490930 into falcosecurity:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants