Add user_known_mount_in_privileged_containers macro #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @mmoyerfigma! It looks like this is your first PR to falcosecurity/falco 🎉 |
mmoyerfigma
force-pushed
the
add-user_known_mount_in_privileged_containers-macro
branch
from
a96c78b
to
f851897
Compare
This adds a new macro `user_known_mount_in_privileged_containers` which allows the easier user-defined exclusions for the "Mount Launched in Privileged Container" rule. This would be cleaner with the exclusions feature, but this feature is not used in the default ruleset yet, if I understand correctly. Signed-off-by: Matt Moyer <[email protected]>
mmoyerfigma
force-pushed
the
add-user_known_mount_in_privileged_containers-macro
branch
from
f851897
to
8e86d89
Compare
Kaizhe
approved these changes
Mar 10, 2022
|
LGTM label has been added. Git tree hash: 008e7177a65d0ccc03f09d61db2f3ff0d2d26464
|
|
Thanks @Kaizhe! Are there any plans to add exception support for all the default rules? |
|
/milestone 0.32.0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, mmoyerfigma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mmoyerfigma
deleted the
add-user_known_mount_in_privileged_containers-macro
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
This adds a new macro
user_known_mount_in_privileged_containerswhichallows the easier user-defined exclusions for the "Mount Launched in
Privileged Container" rule.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
This would be cleaner with exceptions, but this feature is not used in the default ruleset yet, if I understand correctly.
Does this PR introduce a user-facing change?: