extra rules with NIDS, HIDS, ansible, critical-stack, ... #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been working on a very similar set of changes that I just merged in #196, so there are a lot of conflicts now. I'd be happy to take these changes, resolve the conflics myself, and then prepare a new PR with your changes. Is that ok with you? The commits would have my name, but I'd be happy to give you credit in the PR and commit notes. Does that sound reasonable? |
|
As you wish, whoever got the time first. I might be able to do this weekend. |
|
I had time to merge the existing changes with your changes, and opened #200. I'll close this PR and we can work through the changes in the new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge part of rules from my testing environment.
comments welcome