Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell GitHub Action #1962

Merged

Conversation

invidian
Copy link
Contributor

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area tests

What this PR does / why we need it:

Folllow up to #1961 to prevent common typos to be added to the repo.

Does this PR introduce a user-facing change?:

NONE

@invidian invidian changed the title Invidian/add codespell GitHub action Add codespell GitHub Action Mar 29, 2022
@poiana poiana added the size/M label Mar 29, 2022
@invidian invidian mentioned this pull request Mar 29, 2022
@leogr
Copy link
Member

leogr commented Apr 6, 2022

/milestone 0.32.0

@poiana poiana added this to the 0.32.0 milestone Apr 6, 2022
@jasondellaluce
Copy link
Contributor

Hey @invidian, I think this is super helpful. I noticed you based this branch on the one of #1961 and now this is causing merge conflict. Would you be able to rebase this to master? Thanks!

@invidian
Copy link
Contributor Author

I'll rebase soon, sure.

Signed-off-by: Mateusz Gozdek <[email protected]>
Folllow up to falcosecurity#1961 to prevent common typos to be added to the repo.

Signed-off-by: Mateusz Gozdek <[email protected]>
@invidian invidian force-pushed the invidian/add-codespell-github-action branch from c173565 to ac37069 Compare April 16, 2022 19:23
@poiana poiana added size/S and removed size/M labels Apr 16, 2022
@invidian
Copy link
Contributor Author

Rebased. Also had to fix some newly added typos to make CI pass again.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you 👏

/approve

/milestone 0.32.0

@poiana
Copy link
Contributor

poiana commented Apr 20, 2022

LGTM label has been added.

Git tree hash: c304743bb7ed97274720b8475305603b3a0df9ff

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Apr 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invidian, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit b080d20 into falcosecurity:master Apr 20, 2022
@invidian invidian deleted the invidian/add-codespell-github-action branch April 22, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants