Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new: port CI builds to github actions #2000

Merged
merged 9 commits into from
May 13, 2022
Merged

new: port CI builds to github actions #2000

merged 9 commits into from
May 13, 2022

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented May 13, 2022

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana poiana requested review from leodido and leogr May 13, 2022 12:16
@poiana poiana added the size/XL label May 13, 2022
@poiana poiana added size/M and removed size/XL labels May 13, 2022
@FedeDP FedeDP changed the title wip: new: port CI builds to github actions new: port CI builds to github actions May 13, 2022
@FedeDP
fix(ci): fixed centos debug job.
42587e9 
Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP FedeDP changed the title new: port CI builds to github actions wip: new: port CI builds to github actions May 13, 2022
@FedeDP FedeDP changed the title wip: new: port CI builds to github actions new: port CI builds to github actions May 13, 2022
leogr
leogr reviewed May 13, 2022
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it 😍

Just a suggestion (see below!)

.github/workflows/ci.yml Show resolved Hide resolved
FedeDP and others added 2 commits May 13, 2022 16:49
@FedeDP @leogr
Update .github/workflows/ci.yml
8108666 
Signed-off-by: Federico Di Pierro <[email protected]>

Co-authored-by: Leonardo Grasso <[email protected]>
@FedeDP
update(ci): add workflow_dispatch to be able to manually trigger ci.
5188109 
Signed-off-by: Federico Di Pierro <[email protected]>
leogr
leogr approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CircleCI before: 1h 0m 26s (when everything goes well)
CircleCI after: 39m 46s 🤩

This is terrific! 👏

/approve

@poiana poiana added the lgtm label May 13, 2022
@poiana
Copy link
Contributor

poiana commented May 13, 2022

LGTM label has been added.

Git tree hash: 57660bea108143d7058a4074c9060eaca2d8e587

@leogr
Copy link
Member

leogr commented May 13, 2022

/milestone 0.32.0

@poiana poiana added this to the 0.32.0 milestone May 13, 2022
jasondellaluce
jasondellaluce approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

🚀

@FedeDP FedeDP mentioned this pull request May 13, 2022
Closed
53 tasks
@poiana
Copy link
Contributor

poiana commented May 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit a7ebfbf into falcosecurity:master May 13, 2022
@FedeDP FedeDP deleted the new/gh_actions_ci branch May 13, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@jasondellaluce jasondellaluce jasondellaluce approved these changes

@leodido leodido Awaiting requested review from leodido

Assignees

@leogr leogr

@jasondellaluce jasondellaluce

Labels
approved area/build dco-signoff: yes kind/feature lgtm release-note-none size/XL
Projects
None yet
Milestone
0.32.0
Development

Successfully merging this pull request may close these issues.
4 participants
@FedeDP @poiana @leogr @jasondellaluce