-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(build): avoid double build of docker images when pushing to aws ecr #2046
Conversation
…s ecr. Moreover, fixed subtle whitespace-bug in various buildx lines. Signed-off-by: Federico Di Pierro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FedeDP 🤌
🤞
LGTM label has been added. Git tree hash: 867173e8d09fb1cb9939c1ee8188d736bb2579d8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone 0.33.0 |
Signed-off-by: Federico Di Pierro [email protected]
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Moreover, fixed subtle whitespace-bug in various buildx lines.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: