Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): fixed falco-driver-loader driver download url. #2057

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jun 10, 2022

Signed-off-by: Federico Di Pierro [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This is part of a bigger change on how we store drivers on s3 bucket.
Next changes need to be made in test-infra driverkit makefile and will come in the next days.

Does this PR introduce a user-facing change?:

fix(scripts): falco-driver-loader script will now seek for drivers in driver/${ARCH}/ for x86_64 too.

@jasondellaluce
Copy link
Contributor

/milestone 0.33.0

@poiana poiana added this to the 0.33.0 milestone Jun 10, 2022
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/bark

❤️

@poiana
Copy link
Contributor

poiana commented Jun 10, 2022

@jasondellaluce: dog image

In response to this:

/approve

/bark

❤️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link
Contributor

poiana commented Jun 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jun 10, 2022

LGTM label has been added.

Git tree hash: ccbad47ebc494c05f40cc00b10e28177222e7766

@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 10, 2022

Poiana is love, poiana is life ❤️

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we will publish the driver with the new directory structure in time :)

@FedeDP we have to update the documentation too 👇
https://falco.org/docs/getting-started/installation/#install-driver

@poiana poiana merged commit 1327c79 into falcosecurity:master Jun 10, 2022
@FedeDP FedeDP deleted the fix/driver_loader_path branch June 13, 2022 07:37
@jasondellaluce jasondellaluce modified the milestones: 0.33.0, 0.32.1 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants