Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): docker-container buildx engine does not support retagging images. Tag all images together. #2058

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jun 10, 2022

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

… images. Tag all images together.

Signed-off-by: Federico Di Pierro <[email protected]>
@jasondellaluce
Copy link
Contributor

/milestone 0.33.0

@poiana poiana added this to the 0.33.0 milestone Jun 10, 2022
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 10, 2022

LGTM label has been added.

Git tree hash: 34115ecaa7fcb91fc7724beacab94f6b07676e51

@leogr
Copy link
Member

leogr commented Jun 10, 2022

/close

@leogr
Copy link
Member

leogr commented Jun 10, 2022

/reopen

@poiana poiana closed this Jun 10, 2022
@poiana
Copy link
Contributor

poiana commented Jun 10, 2022

@leogr: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented Jun 10, 2022

/reopen

@poiana poiana reopened this Jun 10, 2022
@poiana
Copy link
Contributor

poiana commented Jun 10, 2022

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented Jun 10, 2022

/approve

@poiana
Copy link
Contributor

poiana commented Jun 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit ba6c866 into falcosecurity:master Jun 10, 2022
@FedeDP FedeDP deleted the fix/ecr_tags branch June 10, 2022 10:54
@jasondellaluce jasondellaluce modified the milestones: 0.33.0, 0.32.1 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants