refactor(userspace/falco): reduce app actions dependency on app state and inspector #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
|
/milestone 0.33.0 |
Signed-off-by: Jason Dellaluce <[email protected]>
…action Signed-off-by: Jason Dellaluce <[email protected]>
…es action Signed-off-by: Jason Dellaluce <[email protected]>
…_events action Signed-off-by: Jason Dellaluce <[email protected]>
…info action Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]>
jasondellaluce
force-pushed
the
refactor/reduce-action-inspector-deps
branch
from
b58addb
to
4779ef7
Compare
|
LGTM label has been added. Git tree hash: c70c88d2161936935f381d5d936c86278be3c090
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This PR removes the need of accessing the app state inspector for some actions. They now create an inspector on-the-fly if needed.
Accordingly, the action order has been updated depending on their app state dependencies. Now, actions that do not need a given loading/initialization step are moved before it. For instance, this fixed the
--list-syscall-eventscommand which does not really require a configuration file loaded, but until now failed if no-cwas specified.Which issue(s) this PR fixes:
Special notes for your reviewer:
This supported the work of #2074, for which reducing the internal dependencies on the single app state inspector is crucial in order to start managing more than one.
Does this PR introduce a user-facing change?: