new: add a drop_pct referred to the global number of events
#2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]> Co-authored-by: Shane Lawrence <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
|
@shane-lawrence I think this is something you might be interested in! Looks great @Andreagit97 😄 |
FedeDP
reviewed
Jul 13, 2022
FedeDP
reviewed
Jul 13, 2022
|
LGTM label has been added. Git tree hash: f6ed3e65a1e8f8c18e74646d8703154fe28ce652
|
|
👍👍👍 |
|
/milestone 0.33.0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Looking at this PR from @shane-lawrence I thought that we need a little bit of cleanup here, and moreover, it could be useful to have the
drop_percentagecomputed on the global statistics and not only on the delta. I used thenlohmann jsonlibrary just to simplify the output :) Let me know what you think about thatWhich issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: