Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added arch to bpf download url #2142

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

eric-engberg
Copy link

Signed-off-by: Eric Engberg [email protected]

*What type of PR is this?
/kind bug

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

The url for downloading the prebuild eBPF driver is missing the ARCH in the path

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: Added ARCH to bpf download URL

@eric-engberg
Copy link
Author

Ok third time's the charm then

@FedeDP
Copy link
Contributor

FedeDP commented Jul 21, 2022

Yay!!
/ok-to-test

@eric-engberg
Copy link
Author

When might this get released and the helm chart updated?

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jul 21, 2022

LGTM label has been added.

Git tree hash: 60082556857cfdfcdf661a8253bd36c042a4cb23

@FedeDP
Copy link
Contributor

FedeDP commented Jul 21, 2022

Next Falco release (0.33) is going to be released a couple of months from now, by the end of September!
@leogr @jasondellaluce wdyt?

@eric-engberg
Copy link
Author

Well can't really use eBPF until it's resolved.. can a patch release be done?

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jul 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eric-engberg, FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit c3ddd7d into falcosecurity:master Jul 22, 2022
@jasondellaluce jasondellaluce added this to the 0.33.0 milestone Jul 29, 2022
@jasondellaluce
Copy link
Contributor

/remove-milestone 0.33.0

/milestone 0.32.2

@poiana poiana modified the milestones: 0.33.0, 0.32.2 Aug 2, 2022
@Andreagit97 Andreagit97 mentioned this pull request Aug 2, 2022
19 tasks
@Andreagit97
Copy link
Member

Well can't really use eBPF until it's resolved.. can a patch release be done?

Hey @eric-engberg thank you for all your help, the patch release is finally here 🔊 !!
https://github.com/falcosecurity/falco/releases/tag/0.32.2

@eric-engberg eric-engberg deleted the fix/bpf-download-url branch March 2, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants