cleanup(rules): cleanup rules disabled by default - 2

[incertum]

Signed-off-by: Melissa Kilby [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Be consistent with explicitly tagging rules that are disabled by default with enabled: false. See #2154. Used few bash one liners this time to more reliably spot remaining and (never_true) conditions.

cat rules/falco_rules.yaml | grep "condition: (never_true)" -B1 | grep macro | sed 's/^.*[: ]//' > /tmp/never_true_macros.txt

while read -r line; do CHECK=$(cat rules/falco_rules.yaml | grep "and $line"); if [[ ! -z $CHECK ]]; then echo $CHECK; fi; done < /tmp/never_true_macros.txt

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(Interpreted procs outbound network activity)!: disabled by default
rule(Interpreted procs inbound network activity)!: disabled by default
rule(Contact cloud metadata service from container)!: disabled by default
rule(macro: consider_interpreted_outbound)!: remove unused macro
rule(macro: consider_interpreted_inbound)!: remove unused macro
rule(macro: consider_metadata_access)!: remove unused macro

[jasondellaluce]

/approve

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: incertum, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• rules/OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[poiana]

LGTM label has been added.

Git tree hash: 04580f0ed5ca433915ee16b173b98367a4f10603

[jasondellaluce]

/milestone 0.33.0