Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(userspace/falco, cmake): updated libs to latest master. #2201

Merged
merged 12 commits into from
Sep 20, 2022

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Sep 12, 2022

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area build

/area engine

What this PR does / why we need it:

Adapted API to sinsp::open API break, and simple consumer API break.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update: bumped libs to fd46dd139a8e35692a7d40ab2f0ed2016df827cf.

@jasondellaluce
Copy link
Contributor

This will require bumping the plugin dependencies as well. We prepared -rc releases for this purpose specifically:

I think this should solve most of the failing tests

@leogr
Copy link
Member

leogr commented Sep 16, 2022

/milestone 0.33.0

@poiana poiana added this to the 0.33.0 milestone Sep 16, 2022
FedeDP and others added 4 commits September 16, 2022 15:34
Adapted API to sinsp::open API break, and simple consumer API break.

Signed-off-by: Federico Di Pierro <[email protected]>

Co-authored-by: Andrea Terzolo <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>

Co-authored-by: Andrea Terzolo <[email protected]>
@poiana poiana removed the size/L label Sep 18, 2022
Andreagit97 and others added 2 commits September 19, 2022 09:01
Signed-off-by: Andrea Terzolo <[email protected]>
Co-authored-by: Jason Dellaluce <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
@FedeDP FedeDP changed the title wip: update(userspace/falco, cmake): updated libs to latest master. update(userspace/falco, cmake): updated libs to latest master. Sep 20, 2022
leogr
leogr previously approved these changes Sep 20, 2022
@poiana
Copy link
Contributor

poiana commented Sep 20, 2022

LGTM label has been added.

Git tree hash: b19dfac7b37f64a87d90487d7d231cf9f0608bf8

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion

userspace/falco/app_cmdline_options.cpp Outdated Show resolved Hide resolved
Signed-off-by: Andrea Terzolo <[email protected]>
Co-authored-by: Jason Dellaluce <[email protected]>
Co-authored-by: Leonardo Grasso <[email protected]>
@poiana poiana added the lgtm label Sep 20, 2022
@poiana
Copy link
Contributor

poiana commented Sep 20, 2022

LGTM label has been added.

Git tree hash: 314c4e788ccf9f2f43c6bf6408e1b306b6d5594a

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks!!

@poiana
Copy link
Contributor

poiana commented Sep 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit f57c67c into master Sep 20, 2022
@poiana poiana deleted the update/latest_libs branch September 20, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants