-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(docs): add overview and versioning sections to falco release.md #2205
update(docs): add overview and versioning sections to falco release.md #2205
Conversation
Co-authored-by: Leonardo Grasso <[email protected]> Signed-off-by: Melissa Kilby <[email protected]>
d2fc8ac
to
52db885
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🤩
Just left some minor comments after a first quick look 😃
👍 I plan to do that once we have released |
Co-authored-by: Leonardo Grasso <[email protected]> Signed-off-by: Melissa Kilby <[email protected]>
@leogr Added additional details into the doc as suggested. Ok to ask for more polishing commit. After that we can merge and you can edit the rest in a follow up PR. |
Signed-off-by: Melissa Kilby <[email protected]>
I guess this PR will remain in WIP until the release, so |
LGTM label has been added. Git tree hash: ca63aa90226bca08b492025a4739d6a860d41830
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this, really great effort!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, incertum, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Leonardo Grasso [email protected]
Signed-off-by: Melissa Kilby [email protected]
What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
What this PR does / why we need it:
Add more technical clarity to the release doc, see #2195
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
@leogr - started with adding an overview section and as discussed more information around versioning of Falco components. Perhaps we should adjust the old sections to the new style you started for libs falcosecurity/libs#580? Would you want to take care of the next commit and I can then help polish things afterwards? Please feel free to overwrite and improve anything I wrote so far :)
Does this PR introduce a user-facing change?: