Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(docs): add overview and versioning sections to falco release.md #2205

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

incertum
Copy link
Contributor

Co-authored-by: Leonardo Grasso [email protected]
Signed-off-by: Melissa Kilby [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Add more technical clarity to the release doc, see #2195

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@leogr - started with adding an overview section and as discussed more information around versioning of Falco components. Perhaps we should adjust the old sections to the new style you started for libs falcosecurity/libs#580? Would you want to take care of the next commit and I can then help polish things afterwards? Please feel free to overwrite and improve anything I wrote so far :)

Does this PR introduce a user-facing change?:

NONE

Co-authored-by: Leonardo Grasso <[email protected]>
Signed-off-by: Melissa Kilby <[email protected]>
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🤩

Just left some minor comments after a first quick look 😃

RELEASE.md Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
@leogr
Copy link
Member

leogr commented Sep 15, 2022

@leogr - started with adding an overview section and as discussed more information around versioning of Falco components. Perhaps we should adjust the old sections to the new style you started for libs falcosecurity/libs#580? Would you want to take care of the next commit and I can then help polish things afterwards? Please feel free to overwrite and improve anything I wrote so far :)

👍

I plan to do that once we have released libs (so we at least can say we have tried it 😸 )

@poiana poiana added size/L and removed size/M labels Sep 15, 2022
@incertum
Copy link
Contributor Author

@leogr Added additional details into the doc as suggested. Ok to ask for more polishing commit. After that we can merge and you can edit the rest in a follow up PR.

@leogr
Copy link
Member

leogr commented Sep 27, 2022

I guess this PR will remain in WIP until the release, so
/milestone 0.34.0

@poiana poiana added this to the 0.34.0 milestone Sep 27, 2022
@incertum incertum changed the title [WIP] update(docs): add overview and versioning sections to falco release.md update(docs): add overview and versioning sections to falco release.md Sep 27, 2022
@poiana
Copy link
Contributor

poiana commented Nov 28, 2022

LGTM label has been added.

Git tree hash: ca63aa90226bca08b492025a4739d6a860d41830

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, really great effort!
/approve

@poiana
Copy link
Contributor

poiana commented Nov 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, incertum, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 8f188eb into falcosecurity:master Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants