new(config): explicitly add the simulate_drops config
#2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Terzolo <[email protected]>
|
/milestone 0.34.0 |
leogr
requested changes
Nov 30, 2022
Sorry I pushed "Request change" by mistake :( |
leogr
reviewed
Nov 30, 2022
leogr
approved these changes
Nov 30, 2022
|
LGTM label has been added. Git tree hash: 6251fa406a2a737cce7e3b14862a11deeb5b445b
|
jasondellaluce
approved these changes
Nov 30, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
What this PR does / why we need it:
This PR adds a config that can be used for debugging purposes, the
simulate_dropsconfig. This PR is just a proposal maybe there is a particular reason why we don't expose it directly to the user, any feedback is welcome :)Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: