Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(systemd): solve some issues with systemd unit #2385

Merged
merged 2 commits into from
Jan 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions scripts/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,14 @@ configure_file("${PROJECT_SOURCE_DIR}/scripts/systemd/falcoctl-artifact-follow.s
"${PROJECT_BINARY_DIR}/scripts/systemd" COPYONLY)

# Debian
configure_file(debian/postinst.in debian/postinst)
configure_file(debian/postrm.in debian/postrm)
configure_file(debian/prerm.in debian/prerm)
configure_file(debian/postinst.in debian/postinst COPYONLY)
configure_file(debian/postrm.in debian/postrm COPYONLY)
configure_file(debian/prerm.in debian/prerm COPYONLY)

# Rpm
configure_file(rpm/postinstall.in rpm/postinstall)
configure_file(rpm/postuninstall.in rpm/postuninstall)
configure_file(rpm/preuninstall.in rpm/preuninstall)
configure_file(rpm/postinstall.in rpm/postinstall COPYONLY)
configure_file(rpm/postuninstall.in rpm/postuninstall COPYONLY)
configure_file(rpm/preuninstall.in rpm/preuninstall COPYONLY)

configure_file(falco-driver-loader falco-driver-loader @ONLY)

Expand Down
2 changes: 1 addition & 1 deletion scripts/debian/postinst.in
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ systemctl --system disable 'falcoctl-artifact-follow.service' || true
systemctl --system unmask falcoctl-artifact-follow.service || true

if [ "$1" = "configure" ]; then
if [ -x /usr/bin/dialog ]; then
if [ -x /usr/bin/dialog ] && [ "${FALCO_FRONTEND}" != "noninteractive" ]; then
# If dialog is installed, create a dialog to let users choose the correct driver for them
CHOICE=$(dialog --clear --title "Falco drivers" --menu "Choose your preferred driver:" 12 55 4 \
1 "Manual configuration (no unit is started)" \
Expand Down
2 changes: 1 addition & 1 deletion scripts/rpm/postinstall.in
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ systemctl --system disable 'falcoctl-artifact-follow.service' || true
systemctl --system unmask falcoctl-artifact-follow.service || true

if [ $1 -eq 1 ]; then
if [ -x /usr/bin/dialog ]; then
if [ -x /usr/bin/dialog ] && [ "${FALCO_FRONTEND}" != "noninteractive" ]; then
# If dialog is installed, create a dialog to let users choose the correct driver for them
CHOICE=$(dialog --clear --title "Falco drivers" --menu "Choose your preferred driver:" 12 55 4 \
1 "Manual configuration (no unit is started)" \
Expand Down
3 changes: 0 additions & 3 deletions scripts/systemd/falco-bpf.service
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@ Description=Falco: Container Native Runtime Security with ebpf
Documentation=https://falco.org/docs/
Before=falcoctl-artifact-follow.service
Wants=falcoctl-artifact-follow.service
Conflicts=falco-kmod.service
Conflicts=falco-modern-bpf.service
Conflicts=falco-custom.service

[Service]
Type=simple
Expand Down
3 changes: 0 additions & 3 deletions scripts/systemd/falco-custom.service
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@ Description=Falco: Container Native Runtime Security with custom configuration
Documentation=https://falco.org/docs/
Before=falcoctl-artifact-follow.service
Wants=falcoctl-artifact-follow.service
Conflicts=falco-kmod.service
Conflicts=falco-bpf.service
Conflicts=falco-modern-bpf.service

[Service]
Type=simple
Expand Down
3 changes: 0 additions & 3 deletions scripts/systemd/falco-kmod.service
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ After=falco-kmod-inject.service
Requires=falco-kmod-inject.service
Before=falcoctl-artifact-follow.service
Wants=falcoctl-artifact-follow.service
Conflicts=falco-bpf.service
Conflicts=falco-modern-bpf.service
Conflicts=falco-custom.service

[Service]
Type=simple
Expand Down
3 changes: 0 additions & 3 deletions scripts/systemd/falco-modern-bpf.service
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@ Description=Falco: Container Native Runtime Security with modern ebpf
Documentation=https://falco.org/docs/
Before=falcoctl-artifact-follow.service
Wants=falcoctl-artifact-follow.service
Conflicts=falco-kmod.service
Conflicts=falco-bpf.service
Conflicts=falco-custom.service

[Service]
Type=simple
Expand Down