Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(.github): integrate Go regression tests #2437

Merged
merged 5 commits into from
Jun 13, 2023
Merged

update(.github): integrate Go regression tests #2437

merged 5 commits into from
Jun 13, 2023

Conversation

jasondellaluce
Copy link
Contributor

@jasondellaluce jasondellaluce commented Mar 7, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area tests

/area CI

What this PR does / why we need it:

This brings ring the Go regression tests of https://github.com/falcosecurity/testing into this repo and run them in the Github Actions CI.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(.github): integrate Go regression tests

@poiana poiana added the approved label Mar 7, 2023
@jasondellaluce jasondellaluce force-pushed the wip/go-regression-tests-ci branch 3 times, most recently from ce4ff41 to 969aa3f Compare March 7, 2023 14:41
@jasondellaluce
Copy link
Contributor Author

/milestone 0.35.0

@poiana poiana added this to the 0.35.0 milestone Mar 7, 2023
@jasondellaluce jasondellaluce force-pushed the wip/go-regression-tests-ci branch 7 times, most recently from 39eb98e to 1732bda Compare March 9, 2023 15:23
@jasondellaluce jasondellaluce force-pushed the wip/go-regression-tests-ci branch 6 times, most recently from f746cc9 to e3a2308 Compare April 3, 2023 10:08
@jasondellaluce jasondellaluce force-pushed the wip/go-regression-tests-ci branch 2 times, most recently from eab6103 to 0826237 Compare April 12, 2023 15:44
@poiana poiana added size/XL and removed size/L labels Jun 8, 2023
@jasondellaluce jasondellaluce changed the title WIP: refactor(.github): polish GHA ci and integrate Go regression tests refactor(.github): integrate Go regression tests Jun 12, 2023
@jasondellaluce jasondellaluce changed the title refactor(.github): integrate Go regression tests update(.github): integrate Go regression tests Jun 12, 2023
@jasondellaluce
Copy link
Contributor Author

This should now be ready for review. cc @FedeDP (the GHA CI man).

Once this is reviewed/accepted/merged, I'd propose opening a follow-up PR for deprecating the current Python regression tests (and the falco-tester image, accordingly), since they perform the same checks as the Go testing suite.

@FedeDP
Copy link
Contributor

FedeDP commented Jun 13, 2023

CI Build / test-dev-packages (static) / test-packages (pull_request) Failing after 12s

❎

@FedeDP
Copy link
Contributor

FedeDP commented Jun 13, 2023

Changes LGTM! Do we need to fix up the CI here?

@jasondellaluce
Copy link
Contributor Author

Yep, let me fix the static build test and then we should be good.

@FedeDP
Copy link
Contributor

FedeDP commented Jun 13, 2023 •
edited
Loading

Once this enters, i will update my #2532 to add also the static test on arm64; then i will bump number of nodes for arm64 on prow cluster and we can merge that too!

I think this is the right time to test, since we have eons before the release!

@jasondellaluce
Copy link
Contributor Author

Once this enters, i will update my #2532 to add also the static test on arm64; then i will bump number of nodes for arm64 on prow cluster and we can merge that too!

Lovely. So I guess it will be time to move on from CircleCI for the Falco repo after this.

FedeDP
FedeDP approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Jun 13, 2023
@poiana
Copy link
Contributor

poiana commented Jun 13, 2023

LGTM label has been added.

Git tree hash: 0504e1a76871d434ac7a555f8fc92c710242f1ef

Andreagit97
Andreagit97 approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 78eac4e into master Jun 13, 2023
@poiana poiana deleted the wip/go-regression-tests-ci branch June 13, 2023 08:50
@jasondellaluce jasondellaluce mentioned this pull request Jun 21, 2023
Closed
43 tasks
@jasondellaluce
Copy link
Contributor Author

/milestone 0.35.1

@poiana poiana modified the milestones: 0.36.0, 0.35.1 Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeDP FedeDP FedeDP approved these changes

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

Assignees

@FedeDP FedeDP

@Andreagit97 Andreagit97

Labels
approved area/ci area/tests dco-signoff: yes kind/cleanup lgtm release-note size/XL
Projects
Falco Roadmap
Archived in project
Milestone
0.35.1
Development

Successfully merging this pull request may close these issues.
5 participants
@jasondellaluce @FedeDP @poiana @Andreagit97 @leogr