new(falco/config): add new configurations for http_output #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/milestone 0.35.0 |
Support for user provided CA certificate that can verify the remote server. Users can provide path to the CA certiface store by providing a path to the dir or to the CA store file. If needed users can decide to tell Falco to not verify the server. Signed-off-by: Aldo Lacuku <[email protected]>
alacuku
force-pushed
the
kcl/http_output-certificates
branch
from
46d46b1
to
ba3e236
Compare
|
LGTM label has been added. Git tree hash: 4752520c7702e95bc2b42d4a9c48cdbf40e03477
|
Andreagit97
approved these changes
Mar 30, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, Andreagit97, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind feature
Any specific area of the project related to this PR?
What this PR does / why we need it:
Falco now accepts user-provided Certificates and CA certificate stores that are used to verify the remote server to which the
http_outputis sent.Four new config fields are available under the
http_outputsection in falco.yaml configuration file:Furthermore, this PR decouples Falco as a consumer of the
libcurlfrom the libs. Making the certificate paths configurable at startup time allows Falco to supporthttpsendpoints in every scenario as far as a valid certificate is provided for the remote server.Which issue(s) this PR fixes:
Fixes #2274
Fixes #2448
Special notes for your reviewer:
Does this PR introduce a user-facing change?: