update: sync libs with newest event name APIs #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/milestone 0.35.0 |
|
LGTM label has been added. Git tree hash: 350848ce5b6f83b739136703b91e2c807dca1ea7
|
|
/hold |
|
Something bad in tests :/ |
incertum
reviewed
Apr 4, 2023
| @@ -86,8 +86,8 @@ static void select_event_set(falco::app::state& s, const libsinsp::events::set<p | |||
| std::unordered_set<std::string> user_positive_names = {}; | |||
| std::unordered_set<std::string> user_negative_names = {}; | |||
| extract_base_syscalls_names(s.config->m_base_syscalls_custom_set, user_positive_names, user_negative_names); | |||
| auto user_positive_sc_set = libsinsp::events::names_to_sc_set(user_positive_names); | |||
| auto user_negative_sc_set = libsinsp::events::names_to_sc_set(user_negative_names); | |||
| auto user_positive_sc_set = libsinsp::events::event_names_to_sc_set(user_positive_names); | |||
@Andreagit97, see #2464 was "lucky" enough to encounter these issues locally. Changes in that PR helped ... it's not about the tests being wrong, but some inherent issues with gtests. |
jasondellaluce
force-pushed
the
update/sc-names-fixups
branch
from
10d1abd
to
e916df8
Compare
Signed-off-by: Jason Dellaluce <[email protected]>
…ve last few todos Signed-off-by: Jason Dellaluce <[email protected]>
…631241d448c9ce5b0e35d8dd7f81d814034 Signed-off-by: Jason Dellaluce <[email protected]>
jasondellaluce
force-pushed
the
update/sc-names-fixups
branch
from
e916df8
to
c90e6f6
Compare
|
LGTM label has been added. Git tree hash: 9ef99f1ec4a5a247b66f248dbdc1b315508a664b
|
|
/unhold |
leogr
approved these changes
Apr 4, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, incertum, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
/area engine
What this PR does / why we need it:
Follows up falcosecurity/libs#1023 and adapts the unit tests accordingly.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: