Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): set docker TARGET_ARCH #2557

Merged
merged 1 commit into from
May 19, 2023
Merged

fix(ci): set docker TARGET_ARCH #2557

merged 1 commit into from
May 19, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented May 19, 2023

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI

What this PR does / why we need it:

In buildx TARGET_ARCH was automatically set.
Now that we use plain docker build, we must set it.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

It gets automatically defined in buildx.

Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP FedeDP force-pushed the fix/docker_target_arch branch 2 times, most recently from d5de634 to 7130d0c Compare May 19, 2023 14:16
@FedeDP
Copy link
Contributor Author

FedeDP commented May 19, 2023

Solution tested in this run: https://github.com/falcosecurity/falco/actions/runs/5025201159/jobs/9011863784?pr=2557 and with the workflow:

build-minimal:
    runs-on: ubuntu-20.04
    env:
      TARGET_ARCH: ${{ (github.base_ref == 'master' && 'arm64') || 'amd64' }}
    steps:
      - name: test
        run: echo "${TARGET_ARCH}"

@FedeDP
Copy link
Contributor Author

FedeDP commented May 19, 2023

/milestone 0.35.0

@poiana poiana added this to the 0.35.0 milestone May 19, 2023
@LucaGuerra
Copy link
Contributor

LGTM

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit a28347d into master May 19, 2023
@poiana poiana deleted the fix/docker_target_arch branch May 19, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants