Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): support debian kernel flavors other than normal in falco-driver-loader #2627

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jun 8, 2023

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

What this PR does / why we need it:

Support debian rt and cloud flavors.
See #2625 issue for more info.
Basically, kernel-crawler is going to be fixed to properly output flavored debian kernels, see falcosecurity/kernel-crawler#147.
For Falco 0.35.0, we are only supporting the normal (ie: the one without suffix) kernel flavor; with this patch we will support rt and cloud too.

Which issue(s) this PR fixes:

Fixes #2625

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(scripts): fixed falco-driver-loader to manage debian kernel rt and cloud flavors.

Support debian `rt` and `cloud` flavors.

Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 8, 2023

/hold

@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 8, 2023

/milestone 0.36.0

@poiana poiana added this to the 0.36.0 milestone Jun 8, 2023
@poiana poiana requested review from Kaizhe and leogr June 8, 2023 09:10
@FedeDP FedeDP changed the title fix(scripts): fix falco-driver-loader for debian. fix(scripts): support debian kernel flavors other than normal in falco-driver-loader Jun 8, 2023
@jasondellaluce jasondellaluce mentioned this pull request Jun 21, 2023
43 tasks
@jasondellaluce
Copy link
Contributor

/milestone 0.35.1

@poiana poiana modified the milestones: 0.36.0, 0.35.1 Jun 21, 2023
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, incertum, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,incertum,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 23, 2023

/unhold

@poiana poiana merged commit fbcb971 into master Jun 23, 2023
@poiana poiana deleted the fix/driver-loader-debian branch June 23, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Debian pre-built modules failing
4 participants