Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(proposals): introduce on host anomaly detection framework #2655

Merged

Conversation

incertum
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Formalize an On Host Anomaly Detection Framework.
@falcosecurity/core-maintainers

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(proposals): introduce on host anomaly detection framework

@mstemm
Copy link
Contributor

mstemm commented Aug 21, 2023

I just discovered this issue and would love to hear more about it. Will it be discussed during some community meeting?

@leogr leogr changed the title new(proposals): introduce on host anomaly detection framework docs(proposals): introduce on host anomaly detection framework Aug 22, 2023
@incertum
Copy link
Contributor Author

@mstemm awesome!

Could offer talking about it during next week's community call (Aug 30, 2023) or in October (Oct 4, 2023)? Would next week for example work for you?

@mstemm
Copy link
Contributor

mstemm commented Aug 22, 2023

@mstemm awesome!

Could offer talking about it during next week's community call (Aug 30, 2023) or in October (Oct 4, 2023)? Would next week for example work for you?

Sure, I can attend the Aug 30th meeting. See you then.

@incertum
Copy link
Contributor Author

Tentatively, let's gather additional feedback from the community during our weekly community call on either January 10 or January 17, 2024.

By then, I should have explored a possible plugin integration in more detail and prepared a tentative configuration UX outline.

@incertum incertum force-pushed the proposal-anomaly-detection-framework branch from de448f4 to 7f6c515 Compare January 18, 2024 04:32
@incertum
Copy link
Contributor Author

Started the plugin dev, should have a wip up next week and directly noticed we typically prefix the .so output with lib, plus simply anomalydetection would be less ambiguous and more a more generic/fitting name.

@incertum
Copy link
Contributor Author

Please note that this PR has been open for 8 months now without receiving any review whatsoever. It even appears unprecedented to back up such an important proposal through public talks and serious community call engagement. What needs to happen to move this proposal forward?

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see this pr before, sorry
Reading that it makes sense to me.

/lgtm
/assign @leogr

@poiana
Copy link
Contributor

poiana commented Feb 22, 2024

LGTM label has been added.

Git tree hash: 1cb36c1680c3b1525fb60459b8230086f1c3c6bf

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the delay. I thought this had already been approved during the last core maintainer meeting.

Anyway, the proposal is ok for me, so I am approving.

/milestone 0.38.0

@poiana poiana modified the milestones: TBD, 0.38.0 Feb 22, 2024
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Looking forward to seeing this happen! Great value proposition as always, thanks @incertum!

@poiana poiana merged commit 4ed11d9 into falcosecurity:master Feb 22, 2024
27 checks passed
@poiana
Copy link
Contributor

poiana commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, incertum, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [incertum,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants