-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stats): always initialize m_output field #2789
Conversation
Signed-off-by: Andrea Terzolo <[email protected]>
393f3e4
to
1e0240f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Makes sense, great catch!
LGTM label has been added. Git tree hash: 7446a53d7586ce7915c637ec68493dd32d05b4ae
|
/cc @incertum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
When running Falco with these changes in the default config:
it crashes with a segfault. The reason was that the
m_output
field of the stats writer was not initialized, but we tried to use it anyway in the collection stats phaseWhich issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: