Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): set the right bucket and version for driver legacy #2800

Merged
merged 2 commits into from
Sep 13, 2023
Merged

fix(build): set the right bucket and version for driver legacy #2800

merged 2 commits into from
Sep 13, 2023

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug
/area CI

What this PR does / why we need it:

Download the appropriate version of Falco when building the legacy driver loader image.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

leogr
leogr previously approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poiana poiana added the lgtm label Sep 12, 2023
@poiana
Copy link
Contributor

poiana commented Sep 12, 2023

LGTM label has been added.

Git tree hash: 8646596d6fcf00bc7d0deb1102aa75702f43141b

@FedeDP
Copy link
Contributor

FedeDP commented Sep 12, 2023

/milestone 0.36.0

@poiana poiana added this to the 0.36.0 milestone Sep 12, 2023
@poiana poiana removed the lgtm label Sep 12, 2023
@poiana poiana requested a review from leogr September 12, 2023 15:51
@LucaGuerra
Copy link
Contributor Author

/unhold

FedeDP
FedeDP approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Sep 13, 2023
@poiana
Copy link
Contributor

poiana commented Sep 13, 2023

LGTM label has been added.

Git tree hash: 8e343cadc3f198a3f178837598a9033ebe1d4c08

Andreagit97
Andreagit97 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 60a64ac into falcosecurity:master Sep 13, 2023
17 checks passed
@FedeDP FedeDP mentioned this pull request Sep 14, 2023
Merged
@LucaGuerra LucaGuerra deleted the fix/driver-loader-legacy-version branch September 16, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeDP FedeDP FedeDP approved these changes

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

@leogr leogr Awaiting requested review from leogr

Assignees

@leogr leogr

@FedeDP FedeDP

@Andreagit97 Andreagit97

Labels
approved area/ci dco-signoff: yes kind/bug lgtm release-note-none size/S
Projects
Falco Roadmap
Archived in project
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.
5 participants
@LucaGuerra @poiana @FedeDP @leogr @Andreagit97