Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): enable aarch64 falco driver loader tests. #2961

Merged
merged 1 commit into from
Dec 18, 2023
Merged

chore(ci): enable aarch64 falco driver loader tests. #2961

merged 1 commit into from
Dec 18, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Dec 11, 2023

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 11, 2023

/cc @Andreagit97 @LucaGuerra

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 11, 2023 •
edited
Loading

E: Unable to locate package linux-headers-5.10.201
E: Couldn't find any package by glob 'linux-headers-5.10.201'

It seems like the arm64 node is running on an outdated kernel release? Ie: a kernel release whose kernel-headers are no more in the ubuntu repos?

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 13, 2023

/hold
It seems we are not able to find correct headers for now:

E: Couldn't find any package by glob 'linux-headers-5.10.201'

@FedeDP FedeDP mentioned this pull request Dec 14, 2023
Merged
@FedeDP FedeDP force-pushed the chore/aarch64_driver_loader_tests branch from 0f8ff79 to ffc4ace Compare December 14, 2023 13:24
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 18, 2023

Ported same workaround as in falcosecurity/libs#1566

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 18, 2023

/milestone 0.37.0

@poiana poiana added this to the 0.37.0 milestone Dec 18, 2023
@FedeDP FedeDP force-pushed the chore/aarch64_driver_loader_tests branch from be5fd8d to 3be6d73 Compare December 18, 2023 13:18
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 18, 2023

Ci did pass; squashed in a single commit; ready to get merged!

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 18, 2023

/unhold

@poiana poiana added the lgtm label Dec 18, 2023
Andreagit97
Andreagit97 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 1ab4e9e into master Dec 18, 2023
28 checks passed
@poiana poiana deleted the chore/aarch64_driver_loader_tests branch December 18, 2023 14:26
FedeDP added a commit that referenced this pull request Dec 20, 2023
@FedeDP
chore(ci): revert #2961.
0469efd 
Signed-off-by: Federico Di Pierro <[email protected]>
poiana pushed a commit that referenced this pull request Dec 20, 2023
@FedeDP @poiana
chore(ci): revert #2961.
a2c128e 
Signed-off-by: Federico Di Pierro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@incertum incertum Awaiting requested review from incertum

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

@LucaGuerra LucaGuerra Awaiting requested review from LucaGuerra

Assignees

@leogr leogr

@Andreagit97 Andreagit97

Labels
approved area/ci dco-signoff: yes kind/cleanup lgtm release-note-none size/S
Projects
Falco Roadmap
Archived in project
Milestone
0.37.0
Development

Successfully merging this pull request may close these issues.
4 participants
@FedeDP @poiana @leogr @Andreagit97