Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): added zstd dep to driver loader images #3203

Merged
merged 1 commit into from
May 17, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented May 17, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Recent ubuntu kernel headers packages are zstd compressed. We need zstd to be able to decompress them for the new falcoctl driver kernel headers automatic download logic.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(docker): added zstd to driver loader images

Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP
Copy link
Contributor Author

FedeDP commented May 17, 2024

/milestone 0.38.0
/cc @LucaGuerra @leogr

@poiana poiana requested a review from LucaGuerra May 17, 2024 10:59
@poiana poiana added this to the 0.38.0 milestone May 17, 2024
@poiana poiana added the size/XS label May 17, 2024
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, incertum, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 1bf6a83 into master May 17, 2024
33 checks passed
@poiana poiana deleted the new/zstd_driver-loader branch May 17, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants