Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed the token-permission and pinned-dependencies issue #3299

Merged
merged 2 commits into from
Sep 4, 2024
Merged

fixed the token-permission and pinned-dependencies issue #3299

merged 2 commits into from
Sep 4, 2024

Conversation

harshitasao
Copy link
Contributor

/area CI

What this PR does / why we need it:
fixed the token-permission and pinned-dependencies issue which are reported by scorecard.

Which issue(s) this PR fixes:
Part of #3297

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

@poiana poiana added the size/M label Aug 17, 2024
@harshitasao harshitasao mentioned this pull request Aug 17, 2024
Open
3 tasks
@FedeDP
Copy link
Contributor

FedeDP commented Aug 20, 2024

/milestone 0.39.0

@poiana poiana added this to the 0.39.0 milestone Aug 20, 2024
@harshitasao
made required changes
32083f8 
Signed-off-by: harshitasao <[email protected]>
FedeDP
FedeDP approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Aug 29, 2024
@poiana
Copy link
Contributor

poiana commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, harshitasao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Aug 29, 2024

LGTM label has been added.

Git tree hash: b23686b642e23ec0fd0ddab9830f650f75d1b07d

@FedeDP
Copy link
Contributor

FedeDP commented Aug 29, 2024

/unhold

@FedeDP
Copy link
Contributor

FedeDP commented Sep 4, 2024

cc @sgaist care to re-review? :D

@sgaist
Copy link
Contributor

sgaist commented Sep 4, 2024

@FedeDP AFAICT, there's still the uses: falcosecurity/testing@32e319ae505fb330ae74db4502e605a5e517ff22 line that you wanted reverted that is still present. Did you change your mind about it ?

@FedeDP
Copy link
Contributor

FedeDP commented Sep 4, 2024

@sgaist i double checked and it seems reverted to me! Am I missing anything? 😆

sgaist
sgaist approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@sgaist sgaist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I mixed that with the actions-github-release version.

@poiana poiana merged commit 24a70da into falcosecurity:master Sep 4, 2024
33 checks passed
@FedeDP
Copy link
Contributor

FedeDP commented Sep 10, 2024

This PR broke master CI triggering :/ don't know why.

@FedeDP FedeDP mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgaist sgaist sgaist approved these changes

@FedeDP FedeDP FedeDP approved these changes

@jasondellaluce jasondellaluce Awaiting requested review from jasondellaluce

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

Assignees

@sgaist sgaist

@FedeDP FedeDP

Labels
approved area/ci dco-signoff: yes lgtm release-note-none size/M
Projects
Falco Roadmap
Status: Done
Milestone
0.39.0
Development

Successfully merging this pull request may close these issues.
4 participants
@harshitasao @FedeDP @poiana @sgaist