fix(userspace/falco): properly account for plugin with CAP_PARSING when computing interesting sc set #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FedeDP
commented
Sep 19, 2024
| @@ -163,11 +163,6 @@ falco::app::run_result falco::app::actions::init_inspectors(falco::app::state& s | |||
| std::unordered_set<std::string> used_plugins; | |||
| const auto& all_plugins = s.offline_inspector->get_plugin_manager()->plugins(); | |||
|
|
|||
| if((s.config->m_metrics_flags & METRICS_V2_STATE_COUNTERS)) | |||
…en computing interesting sc set. Signed-off-by: Federico Di Pierro <[email protected]>
FedeDP
force-pushed
the
fix/account_plugin_parsing_sc_set
branch
from
8c01a24
to
6530235
Compare
jasondellaluce
approved these changes
Sep 19, 2024
LucaGuerra
reviewed
Sep 19, 2024
LucaGuerra
approved these changes
Sep 19, 2024
|
/milestone 0.39.0 |
This was referenced Sep 24, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Previously, we were not accounting for plugins with parsing capability while computing the interesting sc set.
This means that we gave no guarantees to plugins writers that the required syscalls (for parsing by the plugin) were actually enabled in the drivers.
This PR fixes that.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: