new(falco): add buffer_format_base64 option, deprecate -b #3358
+28
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.40.0 |
LucaGuerra
changed the title
Signed-off-by: Luca Guerra <[email protected]>
LucaGuerra
force-pushed
the
new/buffer_format_base64
branch
from
7483a14
to
c5d9c92
Compare
LucaGuerra
changed the title
FedeDP
reviewed
Oct 1, 2024
There was a problem hiding this comment.
LGTM!
Again, i have the same comment as #3362 (comment); wdyt?
Signed-off-by: Luca Guerra <[email protected]>
LucaGuerra
force-pushed
the
new/buffer_format_base64
branch
from
c5d9c92
to
3f0e1bc
Compare
|
@FedeDP done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Add
buffer_format_base64option which behaves like-b--print-base64, works in the config file or with-o.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: