Support output formats #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed so that rule_loader (which should be renamed in a later pass..) can tag filters with their index.
This allows the compiler to define per-rule formats. They are currently instantiated and stored on the c++ side, but not being made use of yet.
So that we can individually tag expressions that originate from the same macro (see next commit).
This allows to match events back up with the display output they are associated with.
Before this change, events were only printed if they had all the fields (same behavior as with sysdig when the output format doesn't have a leading "*"). With this change, all events are printed; those that don't have all fields are prefixed with a notification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for output formats in rules (
| <output_format>syntax and plumbing).It works with a companion PR on the sysdig repo that will go soon.
Also a few cleanups and fixes for things I encountered along the way.