token bucket unit tests and redesign (DI of timer function) #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
leodido
force-pushed
the
feat/initial-tests
branch
from
07fce90
to
947a8bc
Compare
|
I'd suggest splitting any PR to add unit tests from a PR that adds formatting changes. |
fntlnz
force-pushed
the
feat/initial-tests
branch
from
d32f560
to
1e06599
Compare
fntlnz
force-pushed
the
feat/initial-tests
branch
from
a9af269
to
d1ddba0
Compare
leodido
force-pushed
the
feat/initial-tests
branch
from
d1ddba0
to
c38d615
Compare
Co-Authored-by: Lorenzo Fontana <[email protected]> Signed-off-by: Leonardo Di Donato <[email protected]>
Co-Authored-by: Lorenzo Fontana <[email protected]> Signed-off-by: Leonardo Di Donato <[email protected]>
Co-authored-by: Lorenzo Fontana <[email protected]> Signed-off-by: Leonardo Di Donato <[email protected]>
Co-Authored-by: Lorenzo Fontana <[email protected]> Signed-off-by: Leonardo Di Donato <[email protected]>
Co-Authored-by: Lorenzo Fontana <[email protected]> Signed-off-by: Leonardo Di Donato <[email protected]>
Co-Authored-By: Lorenzo Fontana <[email protected]> Signed-off-by: Leonardo Di Donato <[email protected]>
Co-Authored-By: Lorenzo Fontana <[email protected]> Signed-off-by: Leonardo Di Donato <[email protected]>
Co-authored-by: Lorenzo Fontana <[email protected]> Signed-off-by: Leonardo Di Donato <[email protected]>
Co-Authored-By: Lorenzo Fontana <[email protected]> Signed-off-by: Leonardo Di Donato <[email protected]>
Co-authored-by: Leonardo Di Donato <[email protected]> Signed-off-by: Lorenzo Fontana <[email protected]>
Co-Authored-By: Lorenzo Fontana <[email protected]> Signed-off-by: Leonardo Di Donato <[email protected]>
Co-Authored-By: Lorenzo Fontana <[email protected]> Signed-off-by: Leonardo Di Donato <[email protected]>
leodido
force-pushed
the
feat/initial-tests
branch
from
c38d615
to
6327874
Compare
poiana
added
release-note
kind/feature
and removed
do-not-merge/release-note-label-needed
needs-kind
labels
leodido
changed the title
fntlnz
approved these changes
Jul 2, 2019
|
LGTM label has been added. Git tree hash: 93b40ccb1809c0c81d6e710fa05155281be269de
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
leodido
changed the title
|
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
What this PR does / why we need it:
The goal of this PR is to introduce an initial set of unit tests for the existing code surface.
Which issue(s) this PR fixes:
Refs #691
Special notes for your reviewer:
This PR introduces the unit test of
token_bucketclass via Catch2 framework for unit testing.It also introduces the fakeit framework for mocking, stubbing, and spying capabilities.
Furthermore it redesigns the
token_bucketclass decoupling the timer function via classical DI (dependency injection) approach.Does this PR introduce a user-facing change?: