Ability to disable event sources #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @fntlnz |
fntlnz
previously approved these changes
Aug 21, 2019
|
LGTM label has been added. Git tree hash: 4a4da1b91eaf36838874ba958dd6b8a80b6d7b83
|
Co-authored-by: Lorenzo Fontana <[email protected]> Signed-off-by: Leonardo Di Donato <[email protected]>
Co-authored-by: Lorenzo Fontana <[email protected]> Signed-off-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]> Co-authored-by: Lorenzo Fonanta <[email protected]>
leodido
force-pushed
the
feat/disable-sources
branch
from
33c8c07
to
85c29f0
Compare
Signed-off-by: Leonardo Di Donato <[email protected]> Co-authored-by: Lorenzo Fontana <[email protected]>
fntlnz
approved these changes
Aug 21, 2019
|
LGTM label has been added. Git tree hash: d86b7774b04dca3506a598cbf0002a086172e32e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
NONE
What this PR does / why we need it:
This PR introduces a flag for the Falco CLI,
--disable-source=(syscall|k8s_audit).It modifies the Falco behaviour accordingly (ie., the way it open the inspector).
Which issue(s) this PR fixes:
Fixes #730
Refs #725
Special notes for your reviewer:
The
--disable-sourceflag accepts only the following values:syscall,k8s_audit. Other values are detected and discarded.This flag can be specified multiple times (for future need).
Nevertheless the user can not disable
syscallandk8s_auditevent sources at the same time.Does this PR introduce a user-facing change?: