Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian package: use systemd if available #989

Closed
wants to merge 43 commits into from

Conversation

juju4
Copy link
Contributor

@juju4 juju4 commented Jan 6, 2020

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

NONE

What this PR does / why we need it:

#484

* switch to systemd if available in debian package
* hardened systemd settings

mstemm and others added 29 commits December 22, 2016 13:25
…G_ORC_UNWINDER or CONFIG_STACK_VALIDATION. (falcosecurity#362)

sysdig-CLA-1.0-signed-off-by: David Archer <[email protected]>
falco-CLA-1.0-signed-off-by: Xiang Dai <[email protected]>

Signed-off-by: Xiang Dai <[email protected]>
falco-CLA-1.0-signed-off-by: Xiang Dai <[email protected]>
@poiana
Copy link
Contributor

poiana commented Apr 18, 2020

@juju4: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

integrations/k8s-using-daemonset/README.md is going to be removed soon by #1157

Please, clean up here too.

@leogr leogr modified the milestones: 0.23.0, 0.24.0 May 18, 2020
@leodido
Copy link
Member

leodido commented Jul 15, 2020

/milestone 0.25.0

@poiana poiana modified the milestones: 0.24.0, 0.25.0 Jul 15, 2020
@leogr
Copy link
Member

leogr commented Aug 19, 2020

Hey @juju4

Are you still working on this PR? Any updates?

@leogr leogr modified the milestones: 0.25.0, 0.26.0 Aug 25, 2020
@krisnova krisnova modified the milestones: 0.26.0, 0.27.0 Sep 24, 2020
@poiana
Copy link
Contributor

poiana commented Oct 17, 2020

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@juju4
Copy link
Contributor Author

juju4 commented Oct 17, 2020

As described, send against dev

don't see any dev branch currently when editing PR

@juju4 juju4 requested a review from leogr October 17, 2020 22:02
@juju4
Copy link
Contributor Author

juju4 commented Oct 17, 2020

I'm pretty sure I did dco but https://github.com/falcosecurity/falco/blob/master/CONTRIBUTING.md is dead
seeing the long list of signoff needed, I think I need some rebase...

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @juju4

Unfortunately, this PR has been opened for a long time, and many things have changed.
I see a lot of merge-commits (that we don't allow to be merged in), and those commits have been not signed off.
So, I believe there are only two options here: rebasing this PR on top of the current master (removing all merge-commits) or creating a new PR.

Btw, recently I noticed that a new similar PR (#1448) was opened, which aims to migrate both RPM and DEB packages. At this point, perhaps it is worth collaborating with the author of the other PR?

@leogr
Copy link
Member

leogr commented Oct 19, 2020

PS
The contribution guideline has been moved here 👇
https://github.com/falcosecurity/.github/blob/master/CONTRIBUTING.md

@leogr
Copy link
Member

leogr commented Mar 12, 2021

Closing this since #1448 has been merged.

@leogr leogr closed this Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants